feat: http请求框架 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: resolved merge conflict
zzsnowy
commented
Sep 18, 2022
| <dependency> | ||
| <groupId>org.springframework</groupId> | ||
| <artifactId>spring-web</artifactId> | ||
| </dependency> |
zzsnowy
commented
Sep 18, 2022
| .throwsIf(!method1.isAnnotationPresent(SHttpSubPath.class)); | ||
|
|
||
| SzyExceptionEnum.HTTP_CENTER_HTTPMETHOD_NOT_FOUND | ||
| .throwsIf(!method1.isAnnotationPresent(SHttpMethod.class)); |
zzsnowy
commented
Sep 18, 2022
|
|
||
| String url = method1.getAnnotation(SHttpSubPath.class).value(); | ||
|
|
||
| Annotation[][] parameterAnnotations = method1.getParameterAnnotations(); |
zzsnowy
commented
Sep 18, 2022
| } | ||
| if(requestParammap.size() > 0){ | ||
| url = url + "?"; | ||
| for(Map.Entry<String, Object> entry : requestParammap.entrySet()){ |
Author
There was a problem hiding this comment.
- 硬编码改成变量，提前一点
- 尝试join替代循环，如果原生join不好用，可以自己写一个JoinUtils
zzsnowy
commented
Sep 18, 2022
| if(parameterAnnotations[i][0].annotationType() == SHttpBody.class){ | ||
| bodyIndex = i; | ||
| } | ||
| } |
zzsnowy
commented
Sep 18, 2022
| log.info("request:" + request); | ||
| RequestCallback requestCallback = restTemplate.httpEntityCallback(request, type); | ||
| ResponseExtractor<ResponseEntity<R>> responseExtractor = restTemplate.responseEntityExtractor(type); | ||
| return (R) ((ResponseEntity<?>)restTemplate.execute(url, httpMethod, requestCallback, responseExtractor)).getBody(); |
Author
There was a problem hiding this comment.
如果返回值为void，请求体为空，param为空，pathVar为空，这些情况排列组合考虑一下
zzsnowy
commented
Sep 18, 2022
| /** | ||
| * @author zzsnowy | ||
| */ | ||
| @Component |
zzsnowy
commented
Sep 18, 2022
| @@ -0,0 +1,109 @@ | |||
| package com.szy.core.httpcenter; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: resolved merge conflict