Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes following review #21

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Changes following review #21

merged 3 commits into from
Apr 23, 2024

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Apr 15, 2024

These are changes made following the reviews of PR #10 to #19

mswwilson
mswwilson previously approved these changes Apr 22, 2024
Copy link

@mswwilson mswwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything I commented on was minor naming things, so merge whenever

@whaeck whaeck changed the base branch from feature/disco to develop April 23, 2024 01:46
@whaeck whaeck dismissed mswwilson’s stale review April 23, 2024 01:46

The base branch was changed.

@whaeck whaeck changed the base branch from develop to feature/disco April 23, 2024 01:47
@whaeck
Copy link
Member Author

whaeck commented Apr 23, 2024

This contains the disco changes as well, so I'll wait until #20 is reviewed.

Base automatically changed from feature/disco to develop April 23, 2024 16:24
@whaeck whaeck merged commit 3346372 into develop Apr 23, 2024
8 checks passed
@whaeck whaeck deleted the fix/review branch April 23, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants