Merge branch 'update/cmake' into 'develop'

Upping the cmake version to 3.27 See merge request njoy/tools!8
njoy · Jan 29, 2025 · 5012089 · 5012089
2 parents 0258fbd + 0a3f7bb
commit 5012089
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -2,7 +2,7 @@
 # Preamble
 ########################################################################
 
-cmake_minimum_required( VERSION 3.24 )
+cmake_minimum_required( VERSION 3.27 )
 
 set( subproject OFF )
 if( DEFINED PROJECT_NAME )
@@ -83,7 +83,7 @@ if( tools.python )
 
   target_link_libraries( tools.python PRIVATE tools )
   target_include_directories( tools.python PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/python/src )
-  target_compile_options( tools.python PRIVATE "-fvisibility=hidden" )
+  set_target_properties( tools.python PROPERTIES CXX_VISIBILITY_PRESET hidden)
   set_target_properties( tools.python PROPERTIES OUTPUT_NAME tools )
   set_target_properties( tools.python PROPERTIES COMPILE_DEFINITIONS "PYBIND11" )
   set_target_properties( tools.python PROPERTIES POSITION_INDEPENDENT_CODE ON )

diff --git a/cmake/dependencies.cmake b/cmake/dependencies.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required( VERSION 3.24 )
+cmake_minimum_required( VERSION 3.27 )
 list(APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/.cmake)
 include( shacl_FetchContent )
 #######################################################################