Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/distributions part3 #8

Merged
merged 12 commits into from
Oct 19, 2024
Merged

Feature/distributions part3 #8

merged 12 commits into from
Oct 19, 2024

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Aug 3, 2024

This PR adds a number of things:

  • enumerators for the reference frames used to describe outgoing distributions (centre of mass and lab) as well as python bindings for these enumerators
  • python bindings and tests for the LegendreAngularDistributions, TabulatedAngularDistributions, TabulatedEnergyDistribution and TabulatedEnergyDistributions
  • TwoBodyDistributionData for two-body scattering distributions
  • UncorrelatedDistributionData for distributions where the outgoing angle and energy distributions are uncorrelated.

These new features are integrated into the ReactionProduct.

@whaeck whaeck requested review from cjosey and nathangibson14 August 3, 2024 20:13
@whaeck whaeck requested a review from joewpeterson September 9, 2024 18:51
cjosey
cjosey previously approved these changes Oct 18, 2024
View reviewed changes
Copy link

@cjosey cjosey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

python/src/DistributionDataType.python.cpp

module,
"DistributionDataType",
"The distribition data type for a reaction product",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Distribition"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed in fix/review

whaeck added a commit that referenced this pull request Oct 18, 2024
@whaeck
Changes following review #8
e56cedc
Base automatically changed from feature/distributions-part2 to develop October 19, 2024 14:24
@whaeck whaeck dismissed cjosey’s stale review October 19, 2024 14:24

The base branch was changed.

@whaeck whaeck merged commit d5f5cec into develop Oct 19, 2024
8 checks passed
@whaeck whaeck deleted the feature/distributions-part3 branch October 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjosey cjosey cjosey left review comments

@nathangibson14 nathangibson14 Awaiting requested review from nathangibson14

@joewpeterson joewpeterson Awaiting requested review from joewpeterson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whaeck @cjosey