-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributions part 1 #6
Conversation
…nto feature/distributions-part1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is currently missing the LegendreAngular stuff in Python. Rest looks good.
|
||
CHECK( InterpolationType::LinearLinear == linear.interpolants()[0] ); | ||
|
||
CHECK_THAT( -1.0 , WithinRel( linear.cosines()[0] ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually went and bothered to verify this linearization. It's below 0.01 relative error, except between the last two nodes. The midpoint is below 0.01, but of course it diverges to infinity as it approaches zero. So, this works as expected.
|
||
CHECK( 3 == result.order() ); | ||
CHECK( 4 == result.coefficients().size() ); | ||
CHECK_THAT( 10.33333333333333, WithinRel( result.coefficients()[0] ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would almost suggest testing these in linearized space where assumptions can be verified easier, but then it would depend on the implementation detail of linearization. But all of these look correct.
Still working on that, but I'm almost done. I'm currently stuck since I upgraded my xcode and no longer have a compiler. |
@cjosey everything is here now |
This adds the TabulatedANgularDistribution object