Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/distributions part5 #10

Merged
merged 22 commits into from
Oct 19, 2024
Merged

Feature/distributions part5 #10

merged 22 commits into from
Oct 19, 2024

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Aug 8, 2024

The next part:

  • adding create functions for ENDF based ReactionProduct and update the create functions for Reaction
  • added logic in creating multiplicities as constant values instead of TabulatedMultiplicity instances when all multiplicity values in the table are constant
  • python bindings for the new distribution components
  • new and updated tests for ReactionProduct, Reaction and ProjectileTarget (focusing mainly on electro-atomic data)
  • I have added another ENDF file for test reasons (incident neutron on Cl35, the only ENDF file to have a LAW=2 using tabulated data)

With this PR, dryad can now read electro-atomic data from an ENDF file. Next up will be photo-atomic data.

whaeck added 21 commits August 4, 2024 21:41
@whaeck
updating endf create functions for MF6 and MF26 reaction products and…
443e27d 
… their multiplicity
@whaeck
Updating create tests
382217c
@whaeck
a small update
694fc8a
@whaeck
Product identifiers can include multiple emission or isomeric states
c965af3
@whaeck
Moving reaction product creation to createReactionProduct
5f5fab3
@whaeck
Adding a create function for TabulatedAngularDistribution
168ee28
@whaeck
Adding create function for TabulatedAngularDistributions
617a6b7
@whaeck
updatign dependency
3fbece4
@whaeck
More create functions
9a7d09e
@whaeck
updating compiler guards
0dc0475
@whaeck
Adding python bindings for distribution data
e04162f
@whaeck
Making a few corrections
0ad59da
@whaeck
Adding TwoBody and Uncorrelated python test
38f34b1
@whaeck
placeholder for MF27
938543b
@whaeck
More tests
5773bb6
@whaeck
distinguishing neutron data in ENDF for tests
68c02b9
@whaeck
Adding logic to convert tabulated to constant multiplicity, started w…
c859314 
…ork on createReactionProduct test
@whaeck
Finishing test for createReactionProduct
5a4b833
@whaeck
Updating test
844e42f
@whaeck
Updating tests for createReaction and createReactions
e94d495
@whaeck
Move common test function to an include file
d979b11
@whaeck whaeck requested review from cjosey and nathangibson14 August 8, 2024 16:50
@whaeck whaeck requested a review from joewpeterson September 9, 2024 18:52
cjosey
cjosey previously approved these changes Oct 18, 2024
View reviewed changes
Base automatically changed from feature/distributions-part4 to develop October 19, 2024 14:27
@whaeck whaeck dismissed cjosey’s stale review October 19, 2024 14:27

The base branch was changed.

@whaeck whaeck merged commit 83e2ee8 into develop Oct 19, 2024
8 checks passed
@whaeck whaeck deleted the feature/distributions-part5 branch October 19, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjosey cjosey cjosey left review comments

@nathangibson14 nathangibson14 Awaiting requested review from nathangibson14

@joewpeterson joewpeterson Awaiting requested review from joewpeterson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whaeck @cjosey