Fix/euler #325
Merged
Fix/euler #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahlerac
approved these changes
Dec 15, 2023
|
I know. I verified it to see when it was introduced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error was introduced so many years ago in the value of the Euler-Mascheroni constant when a number of physical constants were put in the phys.f90 file.
Luckily for us, the impact is limited. The constant is used in the calculation of the Coulomb wave functions - I think - so this will only be seen on nuclides that have charged particle channels in their resonance parameters (LRF=7 only). In the tests only test 20 is impacted as this is the only LRF=7 evaluation we use for our non-regression tests (again, I think). The elastic scattering and capture cross section only have a few values where the 6th digit after the decimal point is different. In MT103 and MT600 (the n,p reaction calculated from the resonance parameters), the impact is only really visible in low cross section values where the 4th to 6th digit after the decimal point are different. This is reflected in the few changes in the total cross section.