Keep a CHANGELOG #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [design]: #detailed-design | ||
|
|
||
| We follow the conventions laid out in [Keep A CHANGELOG](https://github.com/olivierlacan/keep-a-changelog/tree/18adb5f5be7a898d046f6a4acb93e39dcf40c4ad). | ||
|
|
Member
There was a problem hiding this comment.
Might be useful to include the following:
- Guidlines for contributors related to updating the changelog (probably encourage it but make it a soft requirement)
- Note responsibility for maintainer to update CHANGELOG before release including creating a new unreleased section.
Member
There was a problem hiding this comment.
Guidlines for contributors related to updating the changelog (probably encourage it but make it a soft requirement)
👍 to that. We don't want it to block people from contributing, so maintainers can always fix it up later.
Member
|
Looks good generally. |
Contributor
Author
|
Thank you, for the feedback. I already added, that we create an initial CHANGELOG.md. |
Contributor
Author
Member
|
Sorry for the general slowness lately! |
Member
|
Yeah I like this. |
Contributor
Author
|
Given, that I addressed everything @posborne brought up, and @kamalmarhubi did not have any concerns, we (someone) should merge this. |
Member
|
@homu r+ |
Member
|
Looks like @kamalmarhubi will have to hit Merge. |
Member
|
Will have to tinker with permissions... |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nix-rust/nix#363