Skip to content

Conversation

@fwastring
Copy link

Added support for substitute.nvim.
Added tests and plugin support, and myself as a maintainer.

@fwastring
Copy link
Author

Thank you for the quick response! I have changed the code as per your suggestions :)

Copy link
Member

@HeitorAugustoLN HeitorAugustoLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM

@fwastring
Copy link
Author

Good catch, changed it so that aligns with that now.

@fwastring
Copy link
Author

Fixed the ... of the inputs, the other comment was already resolved in an older commit.

Copy link
Member

@HeitorAugustoLN HeitorAugustoLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think you might need to squash your commits to:

maintainers: add fwastring
plugins/substitute: init

@fwastring
Copy link
Author

Thank you, I will do that. How do I request another review to be able to merge?

@HeitorAugustoLN
Copy link
Member

Since you are not a maintainer yet, you can't request reviews, but I will request for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants