do not prefetch git dependencies #382
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
This was referenced Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git prefetching is made unnecessary by switching from
pkgs.fetchgittobuiltins.fetchGit. In addition to simplifying handling git deps this change is a necessary prerequisite to handling git dependencies inside cargo workspaces when running crate2nix in IFD mode.Since this change requires modifying git-fetching code in multiple places I took some steps to make fetching as consistent as possible in each place. Part of that was introduce steps to parse git hashes to verify that those inputs are indeed valid hashes. On the Rust side that is done with the type
CommitHash. On the Nix side there isparseCommitHash.