Add support for cross-compilation, with backcompat #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for new way to replace `buildRustCrate` while also testing the old way.
kolloch
approved these changes
Jan 7, 2021
| @@ -5,6 +5,9 @@ | |||
| , lib | |||
| , stdenv | |||
| , buildRustCrate | |||
| , buildRustCrateForPkgs ? if buildRustCrate != null | |||
| then lib.warn "`buildRustCrate` is deprecated, use `buildRustCrateForPkgs` instead" (_: buildRustCrate) | |||
There was a problem hiding this comment.
I really dig this user guidance, thank you 👍
| then lib.warn "`buildRustCrate` is deprecated, use `buildRustCrateForPkgs` instead" (_: buildRustCrate) | ||
| else pkgs: pkgs.buildRustCrate | ||
| # Deprecated | ||
| , buildRustCrate ? null | ||
| # This is used as the `crateOverrides` argument for `buildRustCrate`. |
There was a problem hiding this comment.
Oh! perhaps I was confused whether the comments were describing the thing above or the thing below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #152 (comment) I made a PR against a PR, but i get not CI that way, so I'm opening this too.