fix: Escape shell arguments in wsl-distro bin helpers #848
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently my use case was to add Windows GPG to extraBin; however, the path is "/mnt/c/Program Files (x86)/GnuPG/bin/gpg.exe" which contains spaces and parentheses that need to be escaped.
Without any modification, the string goes as is in the init script, and the cp/ln commands are just broken.
I temporarily fixed it by escaping the chars in the nix string "/mnt/c/Program\ Files\ \(x86\)/GnuPG/bin/gpg.exe".
However, it would, I think, be way better to escape the params at the script generation.
Summarry :
escapeShellArgto both source and destination arguments incpandlncommands for entries inconfig.wsl.extraBinandcfg.extraBin, ensuring safer shell command execution.