Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches from poi 3.16 #1477

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Conversation

antony-liu
Copy link
Collaborator

  • Fix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not have a patriarch set, so let's walk up the parents to try to find one.

  • Test for another type of xml-bomb

  • use assertStartsWith and assertEndsWith for better unit test error messages

@tonyqus tonyqus added this to the NPOI 2.7.3 milestone Feb 7, 2025
@tonyqus
Copy link
Member

tonyqus commented Feb 7, 2025

LGTM

@tonyqus tonyqus merged commit 5126e0d into nissl-lab:master Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants