sonarjs disables

nirtamir2 · Sep 24, 2024 · 6195044 · 6195044
1 parent e5e91a5
commit 6195044
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/eslint.config.ts b/eslint.config.ts
@@ -23,7 +23,6 @@ export default nirtamir2(
         "sonarjs/no-duplicate-string": "off",
         "sonarjs/no-gratuitous-expressions": "off",
         "sonarjs/no-nested-template-literals": "off",
-        "sonarjs/sonar-no-fallthrough": "off",
         "sonarjs/cognitive-complexity": "off",
         "sonarjs/no-nested-conditional": "off",
         "sonarjs/no-commented-code": "off",

diff --git a/src/configs/javascript.ts b/src/configs/javascript.ts
@@ -175,7 +175,7 @@ export async function javascript(
           { enforceForClassMembers: true, setWithoutGet: true },
         ],
 
-        'antfu/no-top-level-await': 'error',
+        "antfu/no-top-level-await": "error",
         "array-callback-return": "error",
         "block-scoped-var": "error",
         "constructor-super": "error",
@@ -411,6 +411,17 @@ export async function javascript(
     }),
     eslintPluginNoUseExtendNative.configs.recommended,
     sonarjs.configs.recommended,
+    {
+      name: "nirtami2/javascript/sonar/disables",
+      rules: {
+        "sonarjs/new-cap": "off", // sometimes I want api.GET()
+        "sonarjs/todo-tag": "off", // somtimes I want TODO: stuff
+
+        // Bugs in SonarJs
+        "sonarjs/sonar-no-fallthrough": "off", // error when using ESLint 9
+        "sonarjs/void-use": "off", // false positive on promises
+      },
+    },
     ...compat.extends("plugin:clsx/recommended"),
   ];
 }