Split and expand feature tests

Author: tepeds

tests/Feature/SnsHandlerDefaultEventsTest.php

@@ -0,0 +1,79 @@
+<?php
+
+
+namespace Nipwaayoni\Tests\SnsHandler\Feature;
+
+use Aws\Sns\MessageValidator;
+use Illuminate\Support\Facades\Event;
+use Nipwaayoni\SnsHandler\Events\SnsConfirmationRequestReceived;
+use Nipwaayoni\SnsHandler\Events\SnsMessageReceived;
+use Nipwaayoni\SnsHandler\NullMessageValidator;
+use Nipwaayoni\SnsHandler\ServiceProvider;
+use Nipwaayoni\SnsHandler\SnsMessage;
+use Nipwaayoni\Tests\SnsHandler\Events\SnsConfirmationRequestAlphaReceived;
+use Nipwaayoni\Tests\SnsHandler\Events\SnsConfirmationRequestBetaReceived;
+use Nipwaayoni\Tests\SnsHandler\Events\SnsMessageAlphaReceived;
+use Nipwaayoni\Tests\SnsHandler\Events\SnsMessageBetaReceived;
+use Nipwaayoni\Tests\SnsHandler\MakesSnsTests;
+
+class SnsHandlerDefaultEventsTest extends \Nipwaayoni\Tests\SnsHandler\TestCase
+{
+    use MakesSnsTests;
+
+    public function setUp(): void
+    {
+        parent::setUp();
+
+        Event::fake();
+
+        $this->app->bind(MessageValidator::class, NullMessageValidator::class);
+    }
+
+    protected function getPackageProviders($app)
+    {
+        return [ServiceProvider::class];
+    }
+
+    protected function getEnvironmentSetUp($app)
+    {
+        $app['config']->set('sns-handler.confirmation-events', [
+            SnsConfirmationRequestReceived::class => ['*'],
+        ]);
+
+        $app['config']->set('sns-handler.message-events', [
+            SnsMessageReceived::class => ['*'],
+        ]);
+    }
+
+    public function testDispatchesDefaultConfirmationEvent(): void
+    {
+        $data = $this->makeSnsMessageData([
+            'Type' => SnsMessage::SUBSCRIBE_TYPE,
+            'Message' => json_encode(['id' => 123, 'color' => 'red'], true),
+            'SubscribeURL' => 'https://aws.amazon.com/sns/register/abc123'
+        ]);
+
+        $response = $this->postJson('/api/sns/message', $data);
+
+        $this->assertEquals(200, $response->status());
+        Event::assertDispatched(SnsConfirmationRequestReceived::class);
+        Event::assertNotDispatched(SnsConfirmationRequestAlphaReceived::class);
+        Event::assertNotDispatched(SnsConfirmationRequestBetaReceived::class);
+    }
+
+    public function testDispatchesDefaultMessageEvent(): void
+    {
+        $data = $this->makeSnsMessageData([
+            'Type' => SnsMessage::NOTIFICATION_TYPE,
+            'TopicArn' => 'arn:aws:sns:us-west-2:123456789012:MyTopic',
+            'Message' => 'Test message',
+        ]);
+
+        $response = $this->postJson('/api/sns/message', $data);
+
+        $this->assertEquals(200, $response->status());
+        Event::assertDispatched(SnsMessageReceived::class);
+        Event::assertNotDispatched(SnsMessageAlphaReceived::class);
+        Event::assertNotDispatched(SnsMessageBetaReceived::class);
+    }
+}

tests/Feature/SnsHandlerTest.php …s/Feature/SnsHandlerMappedEventsTest.phptests/Feature/SnsHandlerTest.php renamed to tests/Feature/SnsHandlerMappedEventsTest.php tests/Feature/SnsHandlerTest.php renamed to tests/Feature/SnsHandlerMappedEventsTest.php

@@ -16,7 +16,7 @@
 use Nipwaayoni\Tests\SnsHandler\Events\SnsMessageBetaReceived;
 use Nipwaayoni\Tests\SnsHandler\MakesSnsTests;
 
-class SnsHandlerTest extends \Nipwaayoni\Tests\SnsHandler\TestCase
+class SnsHandlerMappedEventsTest extends \Nipwaayoni\Tests\SnsHandler\TestCase
 {
     use MakesSnsTests;
 
@@ -38,31 +38,13 @@ protected function getEnvironmentSetUp($app)
     {
         $app['config']->set('sns-handler.confirmation-events', [
             SnsConfirmationRequestAlphaReceived::class => ['arn:aws:sns:us-west-2:123456789012:AlphaTopic'],
-            SnsConfirmationRequestReceived::class => ['*'],
         ]);
 
         $app['config']->set('sns-handler.message-events', [
             SnsMessageAlphaReceived::class => ['arn:aws:sns:us-west-2:123456789012:AlphaTopic'],
-            SnsMessageReceived::class => ['*'],
         ]);
     }
 
-    public function testDispatchesDefaultConfirmationEvent(): void
-    {
-        $data = $this->makeSnsMessageData([
-            'Type' => SnsMessage::SUBSCRIBE_TYPE,
-            'Message' => json_encode(['id' => 123, 'color' => 'red'], true),
-            'SubscribeURL' => 'https://aws.amazon.com/sns/register/abc123'
-        ]);
-
-        $response = $this->postJson('/api/sns/message', $data);
-
-        $this->assertEquals(200, $response->status());
-        Event::assertDispatched(SnsConfirmationRequestReceived::class);
-        Event::assertNotDispatched(SnsConfirmationRequestAlphaReceived::class);
-        Event::assertNotDispatched(SnsConfirmationRequestBetaReceived::class);
-    }
-
     public function testDispatchesMappedConfirmationEvent(): void
     {
         $data = $this->makeSnsMessageData([
@@ -79,34 +61,34 @@ public function testDispatchesMappedConfirmationEvent(): void
         Event::assertNotDispatched(SnsConfirmationRequestReceived::class);
     }
 
-    public function testDispatchesDefaultMessageEvent(): void
+    public function testDispatchesMappedMessageEvent(): void
     {
         $data = $this->makeSnsMessageData([
             'Type' => SnsMessage::NOTIFICATION_TYPE,
-            'TopicArn' => 'arn:aws:sns:us-west-2:123456789012:MyTopic',
+            'TopicArn' => 'arn:aws:sns:us-west-2:123456789012:AlphaTopic',
             'Message' => 'Test message',
         ]);
 
         $response = $this->postJson('/api/sns/message', $data);
 
         $this->assertEquals(200, $response->status());
-        Event::assertDispatched(SnsMessageReceived::class);
-        Event::assertNotDispatched(SnsMessageAlphaReceived::class);
+        Event::assertDispatched(SnsMessageAlphaReceived::class);
+        Event::assertNotDispatched(SnsMessageReceived::class);
         Event::assertNotDispatched(SnsMessageBetaReceived::class);
     }
 
-    public function testDispatchesMappedMessageEvent(): void
+    public function testReturnsNotFoundForUnmappedMessageEvent(): void
     {
         $data = $this->makeSnsMessageData([
             'Type' => SnsMessage::NOTIFICATION_TYPE,
-            'TopicArn' => 'arn:aws:sns:us-west-2:123456789012:AlphaTopic',
+            'TopicArn' => 'arn:aws:sns:us-west-2:123456789012:BetaTopic',
             'Message' => 'Test message',
         ]);
 
         $response = $this->postJson('/api/sns/message', $data);
 
-        $this->assertEquals(200, $response->status());
-        Event::assertDispatched(SnsMessageAlphaReceived::class);
+        $this->assertEquals(404, $response->status());
+        Event::assertNotDispatched(SnsMessageAlphaReceived::class);
         Event::assertNotDispatched(SnsMessageReceived::class);
         Event::assertNotDispatched(SnsMessageBetaReceived::class);
     }