Add feature tests for mapped events

Author: tepeds

src/SnsBroker.php

@@ -7,10 +7,6 @@
 use Aws\Sns\MessageValidator;
 use Illuminate\Config\Repository as Config;
 use Illuminate\Support\Facades\Log;
-use Nipwaayoni\SnsHandler\Events\SnsConfirmationRequestReceived;
-use Nipwaayoni\SnsHandler\Events\SnsMessageReceived;
-use Nipwaayoni\Tests\SnsHandler\Events\SnsMessageAlphaReceived;
-use Nipwaayoni\Tests\SnsHandler\Events\SnsMessageBetaReceived;
 
 class SnsBroker
 {

tests/Feature/SnsHandlerTest.php

@@ -4,15 +4,16 @@
 namespace Nipwaayoni\Tests\SnsHandler\Feature;
 
 use Aws\Sns\MessageValidator;
-use Illuminate\Http\Client\Request;
 use Illuminate\Support\Facades\Event;
-use Illuminate\Support\Facades\Http;
 use Nipwaayoni\SnsHandler\Events\SnsConfirmationRequestReceived;
 use Nipwaayoni\SnsHandler\Events\SnsMessageReceived;
-use Nipwaayoni\SnsHandler\Listeners\SnsConfirmationRequestListener;
 use Nipwaayoni\SnsHandler\NullMessageValidator;
 use Nipwaayoni\SnsHandler\ServiceProvider;
 use Nipwaayoni\SnsHandler\SnsMessage;
+use Nipwaayoni\Tests\SnsHandler\Events\SnsConfirmationRequestAlphaReceived;
+use Nipwaayoni\Tests\SnsHandler\Events\SnsConfirmationRequestBetaReceived;
+use Nipwaayoni\Tests\SnsHandler\Events\SnsMessageAlphaReceived;
+use Nipwaayoni\Tests\SnsHandler\Events\SnsMessageBetaReceived;
 use Nipwaayoni\Tests\SnsHandler\MakesSnsTests;
 
 class SnsHandlerTest extends \Nipwaayoni\Tests\SnsHandler\TestCase
@@ -22,51 +23,64 @@ class SnsHandlerTest extends \Nipwaayoni\Tests\SnsHandler\TestCase
     public function setUp(): void
     {
         parent::setUp();
-        $this->app->bind(MessageValidator::class, NullMessageValidator::class);
-    }
 
-    protected function getEnvironmentSetUp($app)
-    {
-//        $app['config']->set('sns-handler.sns-class-map', [
-//            'arn:aws:sns:us-west-2:123456789012:MyTopic' => SnsMessageHandlerStub::class,
-//        ]);
+        Event::fake();
+
+        $this->app->bind(MessageValidator::class, NullMessageValidator::class);
     }
 
     protected function getPackageProviders($app)
     {
         return [ServiceProvider::class];
     }
 
-    public function testReturnsNotFoundForUnknownTopicArn(): void
+    protected function getEnvironmentSetUp($app)
     {
-        $this->markTestSkipped("Skipping until we implement enhanced mapping functionality for events.");
-        $data = $this->makeSnsMessageData([
-            'Type' => SnsMessage::NOTIFICATION_TYPE,
-            'TopicArn' => 'arn:aws:sns:us-west-2:123456789012:Unknown',
+        $app['config']->set('sns-handler.confirmation-events', [
+            SnsConfirmationRequestAlphaReceived::class => ['arn:aws:sns:us-west-2:123456789012:AlphaTopic'],
+            SnsConfirmationRequestReceived::class => ['*'],
         ]);
-        $response = $this->postJson('/api/sns/message', $data);
 
-        $this->assertEquals(404, $response->status());
+        $app['config']->set('sns-handler.message-events', [
+            SnsMessageAlphaReceived::class => ['arn:aws:sns:us-west-2:123456789012:AlphaTopic'],
+            SnsMessageReceived::class => ['*'],
+        ]);
     }
 
     public function testDispatchesDefaultConfirmationEvent(): void
     {
-        Event::fake();
-
         $data = $this->makeSnsMessageData([
             'Type' => SnsMessage::SUBSCRIBE_TYPE,
             'Message' => json_encode(['id' => 123, 'color' => 'red'], true),
             'SubscribeURL' => 'https://aws.amazon.com/sns/register/abc123'
         ]);
 
         $response = $this->postJson('/api/sns/message', $data);
+
+        $this->assertEquals(200, $response->status());
         Event::assertDispatched(SnsConfirmationRequestReceived::class);
+        Event::assertNotDispatched(SnsConfirmationRequestAlphaReceived::class);
+        Event::assertNotDispatched(SnsConfirmationRequestBetaReceived::class);
+    }
+
+    public function testDispatchesMappedConfirmationEvent(): void
+    {
+        $data = $this->makeSnsMessageData([
+            'Type' => SnsMessage::SUBSCRIBE_TYPE,
+            'TopicArn' => 'arn:aws:sns:us-west-2:123456789012:AlphaTopic',
+            'SubscribeURL' => 'https://aws.amazon.com/sns/register/abc123'
+        ]);
+
+        $response = $this->postJson('/api/sns/message', $data);
+
         $this->assertEquals(200, $response->status());
+        Event::assertDispatched(SnsConfirmationRequestAlphaReceived::class);
+        Event::assertNotDispatched(SnsConfirmationRequestBetaReceived::class);
+        Event::assertNotDispatched(SnsConfirmationRequestReceived::class);
     }
 
     public function testDispatchesDefaultMessageEvent(): void
     {
-        Event::fake();
         $data = $this->makeSnsMessageData([
             'Type' => SnsMessage::NOTIFICATION_TYPE,
             'TopicArn' => 'arn:aws:sns:us-west-2:123456789012:MyTopic',
@@ -76,7 +90,24 @@ public function testDispatchesDefaultMessageEvent(): void
         $response = $this->postJson('/api/sns/message', $data);
 
         $this->assertEquals(200, $response->status());
-
         Event::assertDispatched(SnsMessageReceived::class);
+        Event::assertNotDispatched(SnsMessageAlphaReceived::class);
+        Event::assertNotDispatched(SnsMessageBetaReceived::class);
+    }
+
+    public function testDispatchesMappedMessageEvent(): void
+    {
+        $data = $this->makeSnsMessageData([
+            'Type' => SnsMessage::NOTIFICATION_TYPE,
+            'TopicArn' => 'arn:aws:sns:us-west-2:123456789012:AlphaTopic',
+            'Message' => 'Test message',
+        ]);
+
+        $response = $this->postJson('/api/sns/message', $data);
+
+        $this->assertEquals(200, $response->status());
+        Event::assertDispatched(SnsMessageAlphaReceived::class);
+        Event::assertNotDispatched(SnsMessageReceived::class);
+        Event::assertNotDispatched(SnsMessageBetaReceived::class);
     }
 }

tests/Unit/SnsBrokerTest.php

@@ -61,6 +61,7 @@ public function testThrowsExceptionForUnknownMessageType(): void
         $this->expectExceptionMessage('Unknown message type: Unknown');
 
         $this->broker->handleRequest($request);
+
         Event::assertNotDispatched(SnsMessageReceived::class);
     }
 
@@ -87,6 +88,7 @@ public function testDispatchesDefaultConfirmationRequestEvent(): void
             ]));
 
         $this->broker->handleRequest($request);
+
         Event::assertDispatched(SnsConfirmationRequestReceived::class);
     }
 
@@ -107,6 +109,7 @@ public function testDispatchesMappedConfirmationRequestEvent(): void
             ]));
 
         $this->broker->handleRequest($request);
+
         Event::assertDispatched(SnsConfirmationRequestAlphaReceived::class);
         Event::assertNotDispatched(SnsConfirmationRequestReceived::class);
     }
@@ -128,6 +131,7 @@ public function testDispatchFirstMappedConfirmationEvent(): void
             ]));
 
         $this->broker->handleRequest($request);
+
         Event::assertDispatched(SnsConfirmationRequestAlphaReceived::class);
         Event::assertNotDispatched(SnsConfirmationRequestBetaReceived::class);
         Event::assertNotDispatched(SnsConfirmationRequestReceived::class);
@@ -164,6 +168,7 @@ public function testDispatchesDefaultNotificationEvent(): void
             ]));
 
         $this->broker->handleRequest($request);
+
         Event::assertDispatched(SnsMessageReceived::class);
     }
 
@@ -183,6 +188,7 @@ public function testDispatchMappedNotificationEvent(): void
             ]));
 
         $this->broker->handleRequest($request);
+
         Event::assertDispatched(SnsMessageAlphaReceived::class);
         Event::assertNotDispatched(SnsMessageReceived::class);
     }
@@ -203,6 +209,7 @@ public function testDispatchFirstMappedNotificationEvent(): void
             ]));
 
         $this->broker->handleRequest($request);
+
         Event::assertDispatched(SnsMessageAlphaReceived::class);
         Event::assertNotDispatched(SnsMessageBetaReceived::class);
         Event::assertNotDispatched(SnsMessageReceived::class);