ENH: Add type hints across miscellaneous methods #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
AddMiscTypeHints
branch
2 times, most recently
from
79645c3 to
5f399c3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 68.75% 68.78% +0.03%
==========================================
Files 20 20
Lines 957 958 +1
Branches 121 121
==========================================
+ Hits 658 659 +1
Misses 254 254
Partials 45 45 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Jan 25, 2025
effigies
reviewed
Jan 25, 2025
effigies
reviewed
Jan 25, 2025
jhlegarreta
force-pushed
the
AddMiscTypeHints
branch
2 times, most recently
from
4bddb5a to
2228520
Compare
oesteban
reviewed
Jan 26, 2025
oesteban
reviewed
Jan 26, 2025
Add type hints across miscellaneous methods. Co-authored-by: Chris Markiewicz <[email protected]>
jhlegarreta
force-pushed
the
AddMiscTypeHints
branch
from
5e697ae to
622101f
Compare
Prefer specifying b-values as `float` types consistently and avoid using `numbers.Number` which seems to be problematic for type checking with `mypy`: python/mypy#3186 Co-authored-by: Chris Markiewicz <[email protected]> Co-authored-by: Oscar Esteban <[email protected]>
Prefer building an array with `None` to fill `S0` if `S0` is `None` instead of a list to increase consistency. Co-authored-by: Chris Markiewicz <[email protected]>
jhlegarreta
force-pushed
the
AddMiscTypeHints
branch
from
622101f to
f005b7e
Compare
oesteban
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noneto fillS0