Skip to content

Fixes to the SPM function script #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes to the SPM function script #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions spm_funcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,16 @@ def get_spm_globals(fname):
spm_vals : array
SPM global metric for each 3D volume in the 4D image.
"""
# +++your code here+++
# return

#- Load the image given by "fname".
img = nib.load(fname)
#- Get the data
data = img.get_fdata()
#- Calculate the SPM global value for each volume.
spm_vals = []
for i in range(data.shape[-1]):
volume = data[:, :, :, i]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using ellipsis here:

Suggested change
volume = data[:, :, :, i]
volume = data[..., i]

spm_vals.append(spm_global(volume))
return spm_vals # Return the result.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the type of spm_vals?

If you read the docstring (line 54 above) it says array, which is very unclear but seems to refer to a numpy.array, however, you return a basic list here. Consider converting it to array before returning or else downstream methods could fail. For instance, with the current implementation you would not be able to do:

average_spm = get_spm_globals(nifti_file).mean()


def main():
# This function run when file executed as a script
Expand Down