source2il: fix missing seq copies #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix `SeqTy` values not being copied upon being passed to union and tuple constructors, resulting in modification to the constructed value to reflect on the original sequence. Details ======= The `TupleCons` (tuple constructor) translation and union construction (in `fitExpr`) emitted a direct use of their operands, ignoring whether the type is trivially copyable or not. `use` - which emits a call to the type's copy procedure where needed - is now used in both cases, fixing the bug. The tests for sequence copies are expanded to also cover tuple, union, and seq constructors.
saem
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
SeqTyvalues not being copied upon being passed to union andtuple constructors, resulting in modifications of the constructed value
reflecting on the original sequence (and vice versa).
Details
The
TupleCons(tuple constructor) translation and union construction(in
fitExpr) emitted a direct use of their operands, ignoring whetherthe type is trivially copyable or not.
use- which emits a call to the type's copy procedure where needed -is now used in both cases, fixing the bug. A raw usage of
Expr.exprpart of
Whiletranslation is - while not causing any issues - alsoreplaced with a call to
use.The tests for sequence copies are expanded to also cover tuple,
union, and seq constructors.