Skip to content

Add support for arm64 on linux #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kraptor wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for arm64 on linux #60

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c12dc5f
Add support for arm64 on linux
kraptor Nov 7, 2024
f10fb01
Apply suggestions from code review
ringabout Feb 11, 2025
e8cbba1
Merge branch 'master' into master
ringabout Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/release_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,3 +179,32 @@ jobs:
tag: ${{ github.ref }}
asset_name: choosenim-${{ env.VERSION }}_macosx_arm
file: ${{ runner.workspace }}/choosenim/bin/choosenim

build-linux_arm64:
runs-on: ubuntu-22.04-arm
steps:
- uses: actions/checkout@v4
- uses: jiro4989/setup-nim-action@v2
Copy link
Member

@ringabout ringabout Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to support linux arm64

Copy link

@veaceslavdoina veaceslavdoina Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use devel option?

    runs-on: ubuntu-22.04-arm64
    steps:
      - uses: jiro4989/setup-nim-action@v2
        with:
          nim-version: devel
          repo-token: ${{ secrets.GITHUB_TOKEN }}
nim -v

Nim Compiler Version 2.3.1 [Linux: arm64]
Compiled at 2025-02-11
Copyright (c) 2006-2025 by Andreas Rumpf
git hash: 1a7bc6d878ff04709ebb1002010fd53b4ba02179
active boot switches: -d:release
nimble -v

nimble v0.16.4 compiled at 2025-02-11 11:17:21
git hash: 123f97a5e4ee9ba35720c0869e19a047c43c797e

with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Build binary
run: |
git config --global --add safe.directory /__w/choosenim/choosenim
nimble install -y
nimble build -d:release -d:staticBuild
ls bin/*

- name: Write release version
run: |
VERSION=${GITHUB_REF_NAME#v}
echo Version: $VERSION
echo "VERSION=$VERSION" >> $GITHUB_ENV

- name: Upload binaries to release/tag
uses: svenstaro/upload-release-action@v2
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
overwrite: true
tag: ${{ github.ref }}
asset_name: choosenim-${{ env.VERSION }}_linux_arm64
file: ${{ runner.workspace }}/choosenim/bin/choosenim
Loading