Skip to content

Conversation

elcritch
Copy link
Contributor

@elcritch elcritch commented Sep 4, 2025

Dependency versions would get messed up with @ being added to the pkg name in some cases.

@Araq
Copy link
Member

Araq commented Sep 4, 2025

Why the heck would @ be part of a package name?

@elcritch
Copy link
Contributor Author

elcritch commented Sep 4, 2025

Why the heck would @ be part of a package name?

Come to think of it shouldn't. I thought maybe it was from some requires format, but that's not a thing.

Hmmm, I'm digging into where the @ is coming from. Probably an errant usage of the pretty print format for a specific version.

@elcritch
Copy link
Contributor Author

elcritch commented Sep 4, 2025

That makes more sense. An old package of mine had an @ in a requires line in an old release. Probably from copying a nimble install pkg@#head or futzing with Nimble.

Now the addRelease logic can handle bad Nimble releases by skipping them. Surprising we haven't needed that yet.

@Araq
Copy link
Member

Araq commented Sep 6, 2025

  1. It's weirdly specific. There are other invalid chars, I'm sure.
  2. I think an Option would work better here rather than an exception, but I don't know for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants