Add registration struct #1
Conversation
This commit adds registration struct to rust file system. struct Registration will be used to register a filesystem type as well as automatically unregister it when the Registration variable is out-of-scop. Signed-off-by: Fox Chen <[email protected]>
| } | ||
|
|
||
| pub fn new_pinned() -> Result<Pin<Box<Self>>> { | ||
| let mut c_fs_type = FileSystemType::default(); // may use DEFAULT_FS_TYPE? |
There was a problem hiding this comment.
The Default impl just returns mem::zeroed(). I am unsure whether we would want to make that more explicit - then again, this is what C code would do. I don't know if there are any safety concerns here, but that is something that we can leave for the upstream people to decide. Until then, default seems fine.
| Ok(Pin::from(Box::try_new(Self::new(c_fs_type))?)) | ||
| } | ||
|
|
||
| pub fn register(&mut self) -> Result { |
There was a problem hiding this comment.
We really want to take self: Pin<&mut Self> here
| Ok(()) | ||
| } | ||
|
|
||
| fn unregister(&mut self) -> Result { |
There was a problem hiding this comment.
Same here I think - this means that the Drop impl has to be implemented similar to https://doc.rust-lang.org/std/pin/index.html#drop-implementation - but that's a good thing in my opinion :)
| fs_type: FileSystemType, | ||
| } | ||
|
|
||
| //Pin self |
There was a problem hiding this comment.
Does this mean anything?
| //Pin self |
No, I was starting on this branch. Can we rebase upstream now?? I found It hard switching between different rust versions :D. |
I am afraid I don't have any time the next couple of days, but we can aim to rebase next week |
No worries. I will submit the fix after the rebase. thank you! |
It's an initial attempt to add Registration to rust fs.
It works as we discussed before: 1)
Registration::new_pinned()creates a registration variable of a specific fs type, 2)Registration::register()registers that fs type, 3) and when the variable is out-of-scop, it will automatically unregister that fs type.I also see you have a
DeclaredFileSystemTypetype that embeds bindings::file_system_type intoFileSystemBase. I'm not sure how to reconcile this.This code has not been fully tested, because it looks like this branch is not complete, I will find a way to port this to main and test the code.