add -p and -l options to specify jar files path and local repository location #4
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds configurability to the Maven installation script by allowing users to specify custom paths for both the input directory containing JAR files and the output Maven repository location. It also includes minor documentation improvements to the README.
- Added command-line arguments
-p/--pathand-l/--local-repositoryfor customizable paths - Updated the
install()function to accept the local repository path as a parameter - Added validation to ensure the specified input directory exists before processing
- Fixed markdown heading formatting in README and documented the new options
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| install-to-project-repo.py | Added two new command-line arguments for configurable paths, updated the install function signature, added directory validation, and refactored code to use the new configurable parameters |
| README.md | Fixed markdown heading syntax, changed "jars" to "libs" for terminology consistency, and documented the new -p and -l command-line options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| args = parser.parse_args() | ||
|
|
||
| if not os.path.isdir(args.path): | ||
| print(f"Error: Directory '{args.path}' does not exist.") |
There was a problem hiding this comment.
The error message uses an f-string but the script doesn't have a shebang for Python 3 explicitly, and the existing shebang points to #!/usr/bin/python which may default to Python 2 on some systems where f-strings are not supported. Consider either updating the shebang to #!/usr/bin/env python3 or using .format() for string formatting to maintain compatibility.
| print(f"Error: Directory '{args.path}' does not exist.") | |
| print("Error: Directory '%s' does not exist." % args.path) |
1 participant
No description provided.