Ssh

[lgund]

A lot of Bugfixes like in pull request #57. But now it's also possible to create ssh connections and Telnet connections. See example here #58

I would like to prefer this as new mayor version 2.0. So we could have 1 big break and then we don't need to talk about this anymore 👍

[nikeee]

This is part of the query client and belongs to the TeamSpeak3QueryApi.Net namespace.

[lgund]

Cause a query command is still part of the query client. So it should stay in the query folder.

[nikeee]

The namespcae layout is as follows:

namespace TeamSpeak3QueryApi.Net: Everything related to the Query protocol itself (that also the regular TS client uses)
namespace TeamSpeak3QueryApi.Net.Specialised: While the name Specialised is disputable, this contains the concrete server query implementation.

One core principle is that the child namespaces should only rely on the parent namespaces (not some sibling namespace) if possible. Introducing a Query namespace would break this semantic.

[lgund]

You mean I should change the class name QueryClient to just Client cause it´s in the namespace Query? (For example)

[nikeee]

Thanks for the PR!
I reviewed parts of it. It's such a large PR that I cannot review this entirely in my spare time.
I think the best way to approach the review is to read all comments and then do some changes.

[lgund]

All changes they have a like will be changed until next week. I am this week not @home.

I know this is a big pr but this isn't a final version for sure. I just want to create a final version with ssh support for everyone. I am sure this brench need some investigation.

[lgund]

So I´am done. Let me know if something else should be fixed or changed.

[nikeee]

A CancellationToken should be returned, not a CancellationTokenSource

[lgund]

Why? This function is not changed. You also returned the CancellationTokenSource. It´s needed for the processingloop. Did I miss something?

[nikeee]

Why internal?

[lgund]

I don´t want that somebody outside this class could change the host. But the Ssh or Telnet client need to set the host and for that it must get more access.

[nikeee]

The namespcae layout is as follows:

namespace TeamSpeak3QueryApi.Net: Everything related to the Query protocol itself (that also the regular TS client uses)
namespace TeamSpeak3QueryApi.Net.Specialised: While the name Specialised is disputable, this contains the concrete server query implementation.

One core principle is that the child namespaces should only rely on the parent namespaces (not some sibling namespace) if possible. Introducing a Query namespace would break this semantic.

[nikeee]

While I think namespaces like Enums etc. might be good for applications, I don't think that a library should use that pattern. For example System.Windows.Forms doesn't have something like Controls, Components etc. either. This way, the core principle mentioned above is easier to follow.

[lgund]

I think this is a matter of taste. I would like to stay like this. It´s for me better readable if we stay in folder and not change the classnames. Or we could change the classnames and stay also in the folders?

[lgund]

Is still interested in this pr, if not I would release it as a new nuget package.

[nikeee]

I'm still interested in merging this! :)

Currently, I'm short on spare time for this project. Maybe we can settle this down this weekend.