Skip to content

Commit

Permalink
add code validations
Browse files Browse the repository at this point in the history
  • Loading branch information
niels committed Nov 17, 2020
1 parent 499223e commit 75adcc4
Show file tree
Hide file tree
Showing 3 changed files with 92 additions and 1 deletion.
14 changes: 14 additions & 0 deletions .github/workflows/hassfest.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: Validate with hassfest

on:
push:
pull_request:
schedule:
- cron: "0 0 * * *"

jobs:
validate:
runs-on: "ubuntu-latest"
steps:
- uses: "actions/checkout@v2"
- uses: home-assistant/actions/hassfest@master
70 changes: 70 additions & 0 deletions custom_components/alarmo/.pylintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
[MASTER]
ignore=tests
ignore-patterns=app_vars
ignored-modules=homeassistant
# Use a conservative default here; 2 should speed up most setups and not hurt
# any too bad. Override on command line as appropriate.
jobs=2
persistent=no
suggestion-mode=yes
extension-pkg-whitelist=taglib

[BASIC]
good-names=id,i,j,k,ex,Run,_,fp,T,ev

[MESSAGES CONTROL]
# Reasons disabled:
# format - handled by black
# locally-disabled - it spams too much
# duplicate-code - unavoidable
# cyclic-import - doesn't test if both import on load
# abstract-class-little-used - prevents from setting right foundation
# unused-argument - generic callbacks and setup methods create a lot of warnings
# too-many-* - are not enforced for the sake of readability
# too-few-* - same as too-many-*
# abstract-method - with intro of async there are always methods missing
# inconsistent-return-statements - doesn't handle raise
# too-many-ancestors - it's too strict.
# wrong-import-order - isort guards this
# fixme - project is in development phase
disable=
format,
abstract-class-little-used,
abstract-method,
cyclic-import,
duplicate-code,
inconsistent-return-statements,
locally-disabled,
not-context-manager,
too-few-public-methods,
too-many-ancestors,
too-many-arguments,
too-many-branches,
too-many-instance-attributes,
too-many-lines,
too-many-locals,
too-many-public-methods,
too-many-return-statements,
too-many-statements,
too-many-boolean-expressions,
unused-argument,
wrong-import-order,
fixme
# enable useless-suppression temporarily every now and then to clean them up
enable=
use-symbolic-message-instead

[REPORTS]
score=no

[REFACTORING]

# Maximum number of nested blocks for function / method body
max-nested-blocks=15

[TYPECHECK]
# For attrs
ignored-classes=_CountingAttr

[FORMAT]
expected-line-ending-format=LFf
9 changes: 8 additions & 1 deletion custom_components/alarmo/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@
"name": "Alarmo",
"documentation": "https://github.com/nielsfaber/alarmo",
"issue_tracker": "https://github.com/nielsfaber/alarmo/issues",
"dependencies": [],
"dependencies": [
"http",
"panel_custom"
],
"after_dependencies": [
"mqtt",
"notify"
],
"codeowners": [
"@nielsfaber"
],
Expand Down

0 comments on commit 75adcc4

Please sign in to comment.