Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Void linux ANSI into main zeitfetch #16

Closed
wants to merge 6 commits into from

Conversation

nidnogg
Copy link
Owner

@nidnogg nidnogg commented Jun 21, 2024

Heya @Xaidee!
I noticed you put in a pretty good rendition of the void linux logo. Are you planning to merge it back in anytime soon?

Cheers!

@Xaidee
Copy link
Contributor

Xaidee commented Jun 21, 2024

Yes I was planning to eventually, maybe with some other distros too but the Void logo was ripped from neofetch and I wasn't sure you'd be okay with that. Just been experimenting with your code on my system in the mean time.

@nidnogg
Copy link
Owner Author

nidnogg commented Jun 22, 2024

Yes I was planning to eventually, maybe with some other distros too but the Void logo was ripped from neofetch and I wasn't sure you'd be okay with that. Just been experimenting with your code on my system in the mean time.

Yeah, so it's fine to include those from neofetch as long as they're credited under https://github.com/nidnogg/zeitfetch?tab=readme-ov-file#disclaimer-for-ascii-logos. (I believe a few came from there).

When you think it's ready, feel free to either ping me here or open another PR.

@Xaidee
Copy link
Contributor

Xaidee commented Jun 22, 2024

I was thinking, especially comparing this implementation to others, it'd be awesome if there was a public database of ASCI and ANSI art that fetch implementations and possibly other projects could pull from to remove the need for individual maintenance of including all operating systems individually

Xaidee added 5 commits June 26, 2024 22:20
(searched through commits and can confirm dylan is the OG author of it)
(searched through commits and can confirm dylan is the OG author of it)
@Xaidee
Copy link
Contributor

Xaidee commented Jun 26, 2024

@nidnogg Sorry for the last messy commits, my code editor messed with README.md and had to fix that manually but this PR should be ready!

@Xaidee
Copy link
Contributor

Xaidee commented Jun 26, 2024

image

I did actually attempt at making an altered version of the original ASCII to make it more readable on black and white while also mimicking the style of the other logos currently in zeitfetch.
Let me know if you'd prefer this version over the neofetch rip and ill update my PR.

EDIT: I've since cleaned the design further after noticing mistakes in the above image

@nidnogg
Copy link
Owner Author

nidnogg commented Jun 26, 2024

image

I did actually attempt at making an altered version of the original ASCII to make it more readable on black and white while also mimicking the style of the other logos currently in zeitfetch. Let me know if you'd prefer this version over the neofetch rip and ill update my PR.

EDIT: I've since cleaned the design further after noticing mistakes in the above image

I like your version better! Let's add that one in.

@Xaidee Xaidee deleted the distro/void branch June 27, 2024 02:20
@Xaidee Xaidee mentioned this pull request Jun 27, 2024
@nidnogg nidnogg closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants