Skip to content

New mess detection algorithm #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2023
Merged

New mess detection algorithm #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdc0b84
draft: new mess detection algo
nickspring Oct 5, 2023
0edaf39
fix bug and change README.md
nickspring Oct 5, 2023
ff8de12
fix: unit tests, removed unused functions
nickspring Oct 6, 2023
ff88fef
fix: unit tests, removed unused functions
nickspring Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ exclude = [

[dependencies]
ahash = "0.8.3"
bitflags = "2.4.0"
cached = "0.46.0"
chardet = { version = "0.2.4", optional = true }
chardetng = { version = "0.1.17", optional = true }
Expand Down
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,22 @@ Python version supports more encodings, but a lot of them are old almost unused

## ⚡ Performance

This package offer better performance than Python version (3 times faster, than MYPYC version of charset-normalizer, 6 times faster than usual Python version).
However, in comparison with `chardet` and `chardetng` packages it is slower but more accurate (I guess because it process whole file chunk by chunk).
This package offer better performance than Python version (4 times faster, than MYPYC version of charset-normalizer, 8 times faster than usual Python version).
In comparison with `chardet` and `chardetng` packages it has approximately the same speed but more accurate.
Here are some numbers.

| Package | Accuracy | Mean per file (ms) | File per sec (est) |
|---------------------------------------------------------------------------------------------|:----------:|:------------------:|:------------------:|
| [chardet](https://crates.io/crates/chardet) | 82.6 % | 2.2 ms | 450 file/sec |
| [chardet](https://crates.io/crates/chardet) | 82.6 % | 3 ms | 333 file/sec |
| [chardetng](https://crates.io/crates/chardetng) | 90.7 % | 1.6 ms | 625 file/sec |
| charset-normalizer-rs | **97.1 %** | **2.7 ms** | 370 file/sec |
| charset-normalizer-rs | **97.1 %** | **1.5 ms** | 666 file/sec |
| [charset-normalizer](https://github.com/Ousret/charset_normalizer) (Python + MYPYC version) | **98 %** | **8 ms** | 125 file/sec |

| Package | 99th percentile | 95th percentile | 50th percentile |
|---------------------------------------------------------------------------------------------|:---------------:|:---------------:|:---------------:|
| [chardet](https://crates.io/crates/chardet) | 8 ms | 2 ms | 0.2 ms |
| [chardetng](https://crates.io/crates/chardetng) | 14 ms | 5 ms | 0.5 ms |
| charset-normalizer-rs | 19 ms | 7 ms | 1.2 ms |
| charset-normalizer-rs | 12 ms | 5 ms | 0.7 ms |
| [charset-normalizer](https://github.com/Ousret/charset_normalizer) (Python + MYPYC version) | 94 ms | 37 ms | 3 ms |

Stats are generated using 400+ files using default parameters. These results might change at any time.
Expand Down
2 changes: 1 addition & 1 deletion src/consts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ lazy_static! {
pub static ref TOO_SMALL_SEQUENCE: usize = 32;
pub static ref TOO_BIG_SEQUENCE: usize = 1_000_000; // 10E6

pub(crate) static ref UTF8_MAXIMAL_ALLOCATION: usize = 128;
pub(crate) static ref UTF8_MAXIMAL_ALLOCATION: usize = 1_112_064;
pub(crate) static ref UNICODE_RANGES_COMBINED: [(&'static str, RangeInclusive<u32>);279] = [
("Control character", 0..=31),
("Basic Latin", 32..=127),
Expand Down
Loading