Pagination #2
Open
Pagination #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 14, 2017 14:18
…e in relation with the pagination
…e in relation with the pagination
… first object if the dataset is not an array. Refactored some methods and variable's names
nicklayb
reviewed
Jun 21, 2017
src/components/TablePagination.js
Outdated
| if (page >= 0 && page < this.props.pageCount) { | ||
| this.props.changeHandler(page); | ||
| } | ||
| this.props.currentPage === 0 ? this.setState({ previousDisabled: true }) : this.setState({ previousDisabled: false }); |
There was a problem hiding this comment.
This whole line could be replace with :
this.setState({ previousDisabled: !!this.props.currentPage });
in fact, the "previousDisabled" property should be replaced by and accessor such as :
isPreviousDisabled() {
return !!this.props.currentPage;
}
src/components/TablePagination.js
Outdated
| this.props.currentPage == this.props.pageCount - 2 ? this.setState({ nextDisabled: true }) : this.setState({ nextDisabled: false }); | ||
| } | ||
|
|
||
| renderPagination() { |
There was a problem hiding this comment.
This method should be divided into smaller ones
| @@ -0,0 +1,20 @@ | |||
| import React from 'react'; | |||
|
|
|||
| class TablePaginationPage extends React.Component { | |||
There was a problem hiding this comment.
This could be a stateless component
src/components/Tabledata.js
Outdated
| export default class Tabledata extends Component { | ||
| constructor(props) { | ||
| super(props); | ||
| this._rowsToDisplay = this.props.rowsToDisplay ? this.props.rowsToDisplay : DEFAULT_ROWS_PER_PAGE; |
added 2 commits
July 17, 2017 09:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pagination system that allows the user to enter a number of row to display on the table. If nothing is specified, the default rows per page is 10.