Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Renderers/SDL2] Don't take addresses of temporaries. #232

Merged
merged 2 commits into from
Jan 29, 2025
Merged

[Renderers/SDL2] Don't take addresses of temporaries. #232

merged 2 commits into from
Jan 29, 2025

Conversation

radiant64
Copy link
Contributor

Fixes compilation errors when including the renderer in C++ sources.

@radiant64
[Renderers/SDL2] Don't take addresses of temporaries.
441434e 
Fixes compilation errors when including the renderer in C++ sources.
FintasticMan
FintasticMan reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@FintasticMan FintasticMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra block isn't needed, as it doesn't affect the lifetime of the rect variable.

@radiant64
Copy link
Contributor Author

The extra block isn't needed, as it doesn't affect the lifetime of the rect variable.

You're absolutely right about that; removed.

@nicbarker
Copy link
Owner

Thanks for opening this one, I forget that this trick is one of those C only things 🙂

@nicbarker nicbarker merged commit e9f2e6c into nicbarker:main Jan 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FintasticMan FintasticMan FintasticMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radiant64 @nicbarker @FintasticMan