-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add store service cleanup #152
Conversation
Not sure who owns this project and could take a look, maybe @arturovt? |
Needs to be rebased on master. Also where the |
@arturovt You're right I've lost initialization sorry but I broke the branch rebasing it to upstream so I'm forced to reopen pull request with all fixes here #154 this one can be discarded |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Reference to Store service object keeps after the module is destroyed.
Issue Number: #116
What is the new behavior?
Reference to Store service object clears after the module is destroyed.
(same behavior as with "injector" reference)
Does this PR introduce a breaking change?
Other information