Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add store service cleanup #152

Closed
wants to merge 14 commits into from
Closed

Conversation

vanmxpx
Copy link
Contributor

@vanmxpx vanmxpx commented Dec 17, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Reference to Store service object keeps after the module is destroyed.

Issue Number: #116

What is the new behavior?

Reference to Store service object clears after the module is destroyed.
(same behavior as with "injector" reference)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@XavierDupessey
Copy link

Not sure who owns this project and could take a look, maybe @arturovt?

@arturovt
Copy link
Member

arturovt commented Mar 27, 2023

Needs to be rebased on master. Also where the store is being set? I see it's initialized and set to null in both places.

@vanmxpx
Copy link
Contributor Author

vanmxpx commented Apr 8, 2023

Needs to be rebased on master. Also where the store is being set? I see it's initialized and set to null in both places.

@arturovt You're right I've lost initialization

sorry but I broke the branch rebasing it to upstream so I'm forced to reopen pull request with all fixes here #154

this one can be discarded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants