Add an online test for an http connect proxy_url #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euank
force-pushed
the
proxy-proto-test
branch
2 times, most recently
from
235aef8 to
da070d0
Compare
|
@euank You still working on this? |
|
I think this is just pending review, @bmpngrok. I've rebased, and the CI failures are just because CI isn't setup to run online tests for PRs from external repos; locally the test added in this PR passes, so it seems good to go from my perspective |
This verifies an http connect proxy works, and since we're making changes around there, it's worth having a basic test to validate it functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This verifies an http connect proxy works, and since we're making changes around there, it's worth having a basic test to validate it functions.