ensure we aren't including/claiming to build any ARM v7 things #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmpngrok
force-pushed
the
bmps/push-slykorrwumys
branch
8 times, most recently
from
cbd5291 to
9395114
Compare
bmpngrok
force-pushed
the
bmps/push-slykorrwumys
branch
from
9395114 to
d7d71c2
Compare
Abdiramen
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we allowed for not building a proper ARM v7 package, we didn't actually nuke that out of the napi config, so it of course still ended up in the optional dependencies, which...yeah, that's not gonna work.
Stop doing that.
Closes #180