Skip to content

Conversation

@znley
Copy link

@znley znley commented Jun 6, 2025

Proposed changes

This patch will allow nginx deb packages to build smoothly on loongarch64 platforms, as the older abseil-cpp is not well supported.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@thresheek
Copy link
Member

Hi @znley !

Thank you for your PR.

As we don't support loongson arch and have no means of checking if it actually builds fine on this or subsequent changes, I'm inclined not to merge this.

Additionally, this isnt enough to fix a debian package build - you'd need to edit the corresponding Makefile to apply that patch too.

@znley
Copy link
Author

znley commented Jun 9, 2025

@thresheek

Additionally, this isnt enough to fix a debian package build - you'd need to edit the corresponding Makefile to apply that patch too.

Thanks for your reminder, I almost forgot debian/Makefile.module-otel.

As we don't support loongson arch and have no means of checking if it actually builds fine on this or subsequent changes, I'm inclined not to merge this.

I understand what you mean. Actually I have already done a local build for nginx. This PR is just for future consideration. If you don't mind, you can leave this request so that I can continue it at a suitable time in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants