Skip to content

Conversation

bavshin-f5
Copy link
Member

Should fix the following error:

[INFO] [stderr]   --- stderr
[INFO] [stderr] 
[INFO] [stderr]   thread 'main' (15) panicked at build/main.rs:139:67:
[INFO] [stderr]   nginx-src build: Os { code: 30, kind: ReadOnlyFilesystem, message: "Read-only file system" }
[INFO] [stderr]   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Also, move default location to the OUT_DIR of nginx-sys.
This should fix the build with read-only source directory.

Fixes nginx#85.
@bavshin-f5 bavshin-f5 requested a review from Copilot September 9, 2025 22:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes docs.rs build failures by changing the cache directory location from CARGO_MANIFEST_DIR to OUT_DIR, which addresses a read-only file system error during documentation builds.

  • Updates nginx-src dependency version from ~1.28.0 to ~1.28.1
  • Refactors cache directory initialization from a function to a static lazy initialization using OUT_DIR
  • Changes cache directory base from manifest directory to build output directory to avoid read-only filesystem issues

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
nginx-sys/Cargo.toml Updates nginx-src dependency version to match new release
nginx-src/Cargo.toml Bumps crate version to 1.28.1 while maintaining NGINX version compatibility
nginx-src/src/download.rs Refactors cache directory handling to use OUT_DIR and static initialization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bavshin-f5 bavshin-f5 requested review from xeioex and ensh63 September 9, 2025 22:49
Copy link
Contributor

@ensh63 ensh63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@bavshin-f5 bavshin-f5 merged commit 54b7316 into nginx:main Sep 10, 2025
15 checks passed
@bavshin-f5 bavshin-f5 deleted the docs-rs-build branch September 10, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants