Skip to content

fix: use CFLAGS from Makefile #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Conversation

ensh63
Copy link
Contributor

@ensh63 ensh63 commented Jul 15, 2025

Proposed changes

Reads C include directories and compiler definitions from Makefile using ALL_INCS and CFLAGS variables.
The lists of include directories and definitions are used to compile expand.c.

Fixes #118 .

Copy link
Member

@bavshin-f5 bavshin-f5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, pass the defines to bindgen via clang_args.

@ensh63 ensh63 force-pushed the makefile-parser branch 4 times, most recently from 5bc5605 to 8a88b7f Compare July 15, 2025 22:27
@ensh63 ensh63 force-pushed the makefile-parser branch from 8a88b7f to 2e09e97 Compare July 15, 2025 22:29
Copy link
Member

@bavshin-f5 bavshin-f5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@bavshin-f5 bavshin-f5 merged commit 2d01596 into nginx:master Jul 15, 2025
15 checks passed
@ensh63 ensh63 deleted the makefile-parser branch July 15, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CFLAGS from the Makefile
2 participants