docs: Adds installation guide for NIC and waf #7688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
✅ Deploy Preview will be available once build job completes!
|
javorszky
force-pushed
the
gabor/issue-7416-nic-appprotectv5
branch
from
1beca46 to
36b5247
Compare
ADubhlaoich
reviewed
Apr 22, 2025
There was a problem hiding this comment.
Generally LGTM.
I've given feedback on a bunch of different things: some of them are just the first instance of something on the basis that the guidance on the rule/style is enough to address other instances.
Please hit the re-request button when you've taken another pass.
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
javorszky
force-pushed
the
gabor/issue-7416-nic-appprotectv5
branch
from
2a8c1c0 to
a2c37bf
Compare
Closes #7416 * Adds installation guide for NIC and waf * users don't need to leave the document * uses the wafv5 json from the examples directory * users are guided to download their key, certificate, and jwt files, and set up license secrets and image pull secrets * users are guided on copying their compiled policy bundle onto the deployment * users are shown how to compile a json into a policy bundle * example applications are deployed and waf is used in those * there are examples of successful and expectedly failed requests
…-helm.md Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Gabor Javorszky <[email protected]>
…-helm.md Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Gabor Javorszky <[email protected]>
…-helm.md Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Gabor Javorszky <[email protected]>
…-helm.md Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Gabor Javorszky <[email protected]>
…-helm.md Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Gabor Javorszky <[email protected]>
javorszky
force-pushed
the
gabor/issue-7416-nic-appprotectv5
branch
from
da9025b to
42b00c2
Compare
ADubhlaoich
previously approved these changes
Apr 23, 2025
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
AlexFenlon
reviewed
Apr 23, 2025
site/content/installation/installing-nic/deploy-with-nap-using-helm.md
Outdated
Show resolved
Hide resolved
Adding tiny nits and wording suggestions Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Gabor Javorszky <[email protected]>
AlexFenlon
previously approved these changes
Apr 24, 2025
ADubhlaoich
previously approved these changes
Apr 24, 2025
ADubhlaoich
approved these changes
Apr 24, 2025
AlexFenlon
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7416
Checklist
Before creating a PR, run through this checklist and mark each as complete.