NAP DoS 4.9 edit pass#1905
Merged
travisamartin merged 17 commits intonap-dos-4.9from May 7, 2026
Merged
Conversation
- Fix product names throughout: 'App Protect DoS' and 'F5 DOS for NGINX'
replaced with correct 'F5 DoS for NGINX'
- Fix 'pre-requisites' → 'prerequisites', '(Purchased or trial)' → lowercase
- Remove first-person voice ('We will configure')
- Replace 'i.e.' with 'for example' throughout
- Fix grammar: 'Bugs fixing' → 'Bug fixes', 'prob.' → 'probe', 'its' → 'it is'
- Replace inline HTML (<br>, <span style=...>) with Markdown equivalents
- Replace hard-coded external links with internal ref shortcodes
- Fix 'Click' → 'Select' per style guide
- Fix heading levels: # Overview → ## Overview in license-secret.md
- Remove weak lead sentence ('This document explains...')
- Fix 'cannot' (was 'can not'), add missing Oxford comma
- Clean up trailing <br> tags from end-of-sentence positions
- Fix double space before 'In offline environments'
github-actions
Bot
added
documentation
…issues - types-of-logs.md: rewrite Request Log section (missed in previous pass) — fix 'App Protect DoS' x3, 'In order to', heading capitalisation, <br> tags - installing...aws.md: remove last <span> HTML tag in step 4 - learn-about-deployment.md: fix remaining 'App Protect DoS' product name - troubleshoot.md: expand XFF (X-Forwarded-For); expand ELK on first mention - kubernetes-with-L4...md: expand eBPF (Extended Berkeley Packet Filter) on first mention in prose - dos-arbitrator.md: expand FQDN (fully qualified domain name); expand mTLS (mutual TLS) on first mention - learn-about-directives-and-policy.md: expand FQDN on first prose mention
The /solutions/about-subscription-licenses.md file was reorganized into a subdirectory. Update the ref to the correct path and anchor: /solutions/about-subscription-licenses/getting-started.md#internet-connected
- Add nd-product: F5DOSN to dos-arbitrator.md and install-post-checks.md - Add missing learn-about-deployment.md to dos-arbitrator.md nd-files list - Remove invalid nd-docs: null from both files
…dos includes - Add nd-product: F5DOSN to all includes missing it - Add nd-files lists based on actual include usage in content files - Remove invalid nd-docs: null from dos-entrypoint.md and dos-waf-entrypoint.md - Fix dos-waf-entrypoint.md nd-files: only used in learn-about-deployment.md - k8s_arbitrator files: nd-product only (not yet referenced in content) - Replace hardcoded syslog IP 10.197.30.219:5261 with <syslog-server-ip>:<port> placeholder in k8s_manifest and k8s_with_ebpf_manifest nginx-conf-configmap files
travisamartin
commented
Apr 30, 2026
Replace non-RFC-5737 example IP 10.197.30.219 (and typo 10.97.30.219) with <SYSLOG_SERVER_IP> placeholder per sensitive-information.md guidance. Affected files: - content/includes/dos/k8s_manifest/dos-nginx-conf-configmap.md - content/includes/dos/k8s_with_ebpf_manifest/dos-nginx-conf-configmap.md - content/nap-dos/deployment-guide/best-practices.md (2 occurrences)
travisamartin
commented
Apr 30, 2026
travisamartin
commented
Apr 30, 2026
5 tasks
✅ Deploy Preview will be available once build job completes!
|
JTorreG
approved these changes
May 1, 2026
The appprotect-dos-arb.md and svc-appprotect-dos-arb.md include files in content/includes/dos/k8s_arbitrator/ are not referenced by any page via the include shortcode, so they serve no purpose. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove the 'Use Helm to install' sections from kubernetes.md and kubernetes-with-L4-accelerated-mitigation.md; only the manifest-based install path remains - Update front matter (description, keywords, nd-summary) to drop all Helm references in both files - Rename kubernetes-with-L4-accelerated-mitigation..md (double dot) to kubernetes-with-L4-accelerated-mitigation.md (single dot) - Update nd-files references in 18 include files under content/includes/dos/ to point to the corrected filename Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rnitzan
approved these changes
May 4, 2026
Contributor
|
Hi @travisamartin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editorial pass on files introduced or updated in the
nap-dos-4.9PR. No technical content has been changed.Changes
App Protect DoS,NGINX App Protect DoS,F5 DOS for NGINX→F5 DoS for NGINXthroughoutdescription,keywords, andnd-content-typefront matter; correctednd-productandnd-filesin all include files; removed invalidnd-docs: nullClick→Select,i.e.→for example,In order to→To,Bugs fixing→Bug fixes, and similar style issues; removed inline HTML (<br>,<span>) in favour of Markdowndocs.nginx.comURLs with{{< ref >}}shortcodes; fixed a broken ref in license-secret.md pointing to a file that was reorganised into a subdirectory10.197.30.219(and typo variant10.97.30.219) with<SYSLOG_SERVER_IP>placeholder per sensitive-information.mdType of change