Add default syslog server #1317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley
approved these changes
Oct 14, 2025
| napSyslogServersMap := make(map[string]bool) | ||
| for _, server := range napSyslogServers { | ||
| napSyslogServersMap[server] = true | ||
| func (oc *Collector) findAvailableSyslogServers(ctx context.Context, napSyslogServer string) string { |
There was a problem hiding this comment.
Suggested change
| func (oc *Collector) findAvailableSyslogServers(ctx context.Context, napSyslogServer string) string { | |
| func (oc *Collector) findAvailableSyslogServer(ctx context.Context, napSyslogServer string) string { |
internal/config/config.go
Outdated
| fs.String( | ||
| SyslogServerPort, | ||
| DefSyslogServerPort, | ||
| "The port Agent will start the syslog server for Nginx App Protect Security violations on", |
There was a problem hiding this comment.
Suggested change
| "The port Agent will start the syslog server for Nginx App Protect Security violations on", | |
| "The port Agent will start the syslog server on for logs collection", |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
- Coverage 86.37% 86.25% -0.12%
==========================================
Files 102 102
Lines 12540 12550 +10
==========================================
- Hits 10831 10825 -6
- Misses 1231 1249 +18
+ Partials 478 476 -2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Akshay2191
approved these changes
Oct 14, 2025
dhurley
reviewed
Oct 22, 2025
sean-breen
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added syslog server port option in agent config
Default value is
1514, agent will parse the NGINX config for Nap syslog server directives, when one is found agent will check if the host is valid and then check if the port matches the configured syslog server port in the config (or default if not set)If the agent fails to find a valid syslog server it will log the following warning, which contains the configured port
Changed NapSyslogServers in NginxConfigContext to a single value as we no longer allow multiple syslog servers.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)