Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check - verification of jobs #84

Open
wants to merge 2 commits into
base: centos-ci
Choose a base branch
from

Conversation

psathyan
Copy link

@psathyan psathyan commented Mar 11, 2025

The verification of jobs check is failing due to missing macro definition path.

In this pull request, there are two changes

  • Moving the actions/checkout to version 4 due to Node.js 16 actions are deprecated.
  • Including the macros definition path along with the job definition for running jenkins-jobs test

@dang
Copy link

dang commented Mar 12, 2025

posix-compliance is failing? Can you look at this? It may be unrelated.

The actions/checkout is now updated to 4 to avoid Node.js 16
deprecation warning.

Signed-off-by: Pragadeeswaran Sathyanarayanan <[email protected]>
The job definitions include macros defined in globals/macros
hence testing of job definitions will fail. The failure will
occur only when the job definition contains the pre-defined
macros.

Here the marcos path is included along with the job definition.

Signed-off-by: Pragadeeswaran Sathyanarayanan <[email protected]>
@psathyan psathyan changed the title Update checkout action version to 4 Fix check - verification of jobs Mar 13, 2025
@psathyan
Copy link
Author

posix-compliance is failing? Can you look at this? It may be unrelated.

Sure.

Including the globals/macros with jobs enables the check to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants