Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update footer.css #80

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Update footer.css #80

merged 3 commits into from
Oct 8, 2024

Conversation

sarthakjalan05
Copy link
Contributor

fixed issue #22
please check and tell me if you need more refinements.
@nfoert

@nfoert
Copy link
Owner

nfoert commented Oct 6, 2024

Hi, thanks for working on this! It appears that this is working as intended on the index page but the positioning of the footer has some issues on other pages when using the mobile view inspector

I don't know exactly why this is, I've had troubles with getting the footer positioning to work correctly in the past

Screen Shot 2024-10-06 at 19 43 24
/home and /authentication

@sarthakjalan05
Copy link
Contributor Author

Hi, thanks for working on this! It appears that this is working as intended on the index page but the positioning of the footer has some issues on other pages when using the mobile view inspector

I don't know exactly why this is, I've had troubles with getting the footer positioning to work correctly in the past

Screen Shot 2024-10-06 at 19 43 24 /home and /authentication

sure I am working on that @nfoert

mobile view footer issue fixed
@sarthakjalan05
Copy link
Contributor Author

Hi @nfoert please check I have fixed both the pages. Let me know if you need some other changes :). And if not please merge these under the hacktoberfest tag.

@nfoert
Copy link
Owner

nfoert commented Oct 7, 2024

@sarthakjalan05, this does work as intended now! However, the point of the footer.css file was to allow an organized way to add the necessary footer styles to every page, is is possible to put all of the new CSS rules just in footer.css instead of home.css and authentication.css?

@nfoert nfoert added the hacktoberfest A good issue for hacktoberfest 2024 label Oct 7, 2024
@sarthakjalan05
Copy link
Contributor Author

@nfoert I tried to do what you asked but I couldn't find a way to do that.

@nfoert
Copy link
Owner

nfoert commented Oct 8, 2024

I tried to do what you asked but I couldn't find a way to do that.

No worries @sarthakjalan05, thanks for working on this! I made a small change, position: sticky had some strange behaviors on smaller screens, and there was some unused styles, otherwise this has been finished, I'll get it merged now!

@nfoert nfoert merged commit aceca0c into nfoert:main Oct 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest A good issue for hacktoberfest 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants