Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding extra services functionality #325

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

eik-dahms
Copy link
Contributor

@eik-dahms eik-dahms commented Feb 11, 2025

feature: users can add non dataplant services
reason: local run gitlab/ datahub instances, testing and development of instances
resolves #56

Workflow:

New Service View

Bildschirmfoto vom 2025-02-11 13-28-10

An additional panel has been added where additional services are show and can be managed.

Add Service Dialog

Bildschirmfoto vom 2025-02-11 13-28-31

The user can add services with or without client secret. (Depends how application is set up in gitlab)

Remove Service Dialog

Bildschirmfoto vom 2025-02-11 13-51-08

User can also remove previously added service.


This features strictly separates Dataplant services and services added by the user. Meaning the user can not change the hardcoded dataplant services or remove them. Added services are stored in a separate config file. Services with already existing URLs can not be added or changed.


In general UI, datamodels and functionality have been altered such that no functionality was taken and everything else works as expected.

@JonasLukasczyk
Copy link
Collaborator

Thank you for putting this together. This will add quite a lot of code, so I want to make sure that there is no simpler way to do this. For example, is there a good reason why you added an additional datahub file instead of just updating the original one? I think you could apply all your changes to this single file instead. Making the distinction between the original and additional case causes a lot of code bloat like:

export const CredentialStore: CredentialStoreType = {
  /** manage credentials for different datahubs */
  credential_file_dataplant: CREDENTIALS_DATAPLANT, 
  credential_file_additional: CREDENTIALS_ADDITIONAL, 
  credentials: {dataplant: {}, additional: {}},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] change the DataHub used
2 participants