Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GSMR test data #1567

Merged
merged 2 commits into from
Mar 26, 2025
Merged

add GSMR test data #1567

merged 2 commits into from
Mar 26, 2025

Conversation

juliaapolonio
Copy link

Hi

I'd like to add these test data for GSMR module (nf-core/modules#7975).

jfy133
jfy133 reviewed Mar 26, 2025
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to describe the files in the main README, but otherwise looks OK to me

@juliaapolonio
Copy link
Author

Hi! Sorry I missed this... Is it good to go now?

jfy133
jfy133 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge @juliaapolonio

@juliaapolonio juliaapolonio merged commit 4500407 into nf-core:modules Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mribeirodantas mribeirodantas mribeirodantas approved these changes

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliaapolonio @mribeirodantas @jfy133