Skip to content

Module to register study for assembly uploads#18

Merged
ochkalova merged 11 commits intonf-core:devfrom
alisha246:feature/register_study
Oct 29, 2025
Merged

Module to register study for assembly uploads#18
ochkalova merged 11 commits intonf-core:devfrom
alisha246:feature/register_study

Conversation

@alisha246
Copy link
Contributor

#8

  • Created module for registering study for metagenome assembly submissions to ENA.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/seqsubmit branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@alisha246 alisha246 requested a review from ochkalova October 29, 2025 11:35
@alisha246 alisha246 self-assigned this Oct 29, 2025
type: value
description: |
Library information with the study.
Example: "metagenome"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 options are supported: metagenome or metatranscriptome. Please add this info to the description

identifier: null

input:
### TODO nf-core: Add a description of all of the variables used as input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all TODO comments


output:
### TODO nf-core: Add a description of all of the variables used as output
bam:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's name is different, I think it's study_accession, but check please

- study:
type: value
description: |
Study accession or name to register in ENA.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Study accession that has been registered in ENA.

@ochkalova ochkalova self-requested a review October 29, 2025 13:25
Copy link
Contributor

@ochkalova ochkalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🥇

@ochkalova ochkalova merged commit c87eec5 into nf-core:dev Oct 29, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants