Skip to content

Fix minimum quorum for pipeline approval voting system #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix minimum quorum for pipeline approval voting system #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab5b1fe
Fix minimum quorum for pipeline approval
jfy133 Aug 15, 2025
f5410b1
Update .github/workflows/pipeline_approval.yml
jfy133 Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pipeline_approval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:

const teamMembers = await getTeamMembers();
console.log('Core and Maintainers team members:', teamMembers);
const quorum = Math.ceil(teamMembers.length / 2);
const quorum = 2;
console.log(`Quorum set to ${quorum}.`);

// Helper for list formatting and complete status body
Expand All @@ -75,7 +75,7 @@ jobs:
const approvers = [...approvalsSet];
const rejecters = [...rejectionsSet];
const awaiting = awaitingArr;
let body = `## Pipeline approval status: ${status}\n\nPipeline has approvals from ${approvalsSet.size}/${quorum} required @core-team quorum.\n\n`;
let body = `## Pipeline approval status: ${status}\n\nPipeline has approvals from ${approvalsSet.size}/${quorum} required @nf-core/core and @nf-core/maintainers quorum.\n\n`;
if (approvers.length > 0 || rejecters.length > 0 || awaiting.length > 0) {
body += `|Review Status|Core and Maintainer Team members|\n|--|--|\n`;
if (approvers.length > 0) {
Expand Down