Skip to content

Fix unstable sort order for combine-collapse #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johandahlberg wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix unstable sort order for combine-collapse #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/local/pixelator/single-cell-pna/combine_collapse/tests/main.nf.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ nextflow_process {


test("PNA combine collapse - stub") {
tag "stub"

options "-stub"

Expand Down
6 changes: 3 additions & 3 deletions subworkflows/local/pna/main.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ workflow PNA {
def newMeta = data[0][0].clone()
newMeta.remove('parts')

// Strip the duplicates meta from each element
def parquet = data.collect { _meta, collapsed, _reports -> collapsed }.flatten()
def reports = data.collect { _meta, _collapsed, reports -> reports }.flatten()
// Strip duplicate meta and keep a stable ordering to avoid cache misses on resume.
def parquet = data.collect { _meta, collapsed, _reports -> collapsed }.flatten().sort { it.toString() }
def reports = data.collect { _meta, _collapsed, reports -> reports }.flatten().sort { it.toString() }
[newMeta, parquet, reports]
}

Expand Down
Loading