Fix GString equality checks with String #6330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bentsherman
force-pushed
the
fix-lazy-gstrings
branch
from
f4db36e to
b12e2d2
Compare
This was
linked to
issues
Aug 6, 2025
bentsherman
force-pushed
the
fix-lazy-gstrings
branch
from
ab74df5 to
2041fcf
Compare
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
force-pushed
the
fix-lazy-gstrings
branch
from
2041fcf to
7c040c7
Compare
christopher-hakkaart
approved these changes
Aug 7, 2025
| Nextflow will evaluate this directive dynamically if it references task inputs. Directives that use an explicit closure are still resolved dynamically. | ||
|
|
||
| :::{note} | ||
| Process configuration options must still be specified with a closure in order to be dynamic. |
There was a problem hiding this comment.
Suggested change
| Process configuration options must still be specified with a closure in order to be dynamic. | |
| Process configuration options must be specified with a closure to be dynamic. |
| :::{versionadded} 25.10 | ||
| ::: | ||
|
|
||
| Dynamic directives do not need to be wrapped in a closure when using the {ref}`strict syntax <strict-syntax-page>`: |
There was a problem hiding this comment.
Suggested change
| Dynamic directives do not need to be wrapped in a closure when using the {ref}`strict syntax <strict-syntax-page>`: | |
| Dynamic directives do not need to be wrapped in closures when using the {ref}`strict syntax <strict-syntax-page>`: |
Treating Dynamic directives as plural
| ``` | ||
|
|
||
| Note, however, that the latter syntax can be used both for a directive's main argument (as in the above example) and for a directive's optional named attributes, whereas the closure syntax is only resolved dynamically for a directive's main argument. | ||
| Nextflow will evaluate this directive dynamically if it references task inputs. Directives that use an explicit closure are still resolved dynamically. |
There was a problem hiding this comment.
Suggested change
| Nextflow will evaluate this directive dynamically if it references task inputs. Directives that use an explicit closure are still resolved dynamically. | |
| Nextflow will evaluate directives dynamically if they reference task inputs. Directives that use an explicit closure are still resolved dynamically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the semantics of GStrings and lazy expressions in the strict syntax.
GStrings are coerced into Strings by appending
.toString()under the hood, so that equality checks like"${'test'}" == 'test'are correct.Lazy expressions in process inputs/outputs/directives are handled more consistently. Before, only GStrings and property expressions were lazily evaluated. Now, any expression that references a variable is wrapped in a closure.