Skip to content

detect tests that spawn subprocesses which leak handles #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 18, 2022
Merged

detect tests that spawn subprocesses which leak handles #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
230a277
[nextest-runner] switch main runner loop to tokio
sunshowers Jul 15, 2022
d4bdef7
[nextest-runner] switch signal handler to using tokio
sunshowers Jul 15, 2022
6c18314
[config] show failed, flaky and slow tests in the final status output
sunshowers Jul 17, 2022
c7118b9
[nextest-runner] switch to tokio process handling APIs
sunshowers Jul 15, 2022
2523035
[nextest-runner] a couple minor fixes for dylib paths
sunshowers Jul 17, 2022
f8d148f
[nextest-runner] switch list step to tokio processes
sunshowers Jul 17, 2022
f8ebb67
[config] remove retries from integration tests
sunshowers Jul 17, 2022
473a8a5
[fixtures] add a test with a leaky subprocess
sunshowers Jul 15, 2022
4aa4107
[nextest-runner] expose leaky tests in the UI
sunshowers Jul 15, 2022
cabc1eb
[nextest-runner] configure handle inheritance on Windows
sunshowers Jul 18, 2022
b81d5ba
[nextest-runner] always close stdin before running tests
sunshowers Jul 18, 2022
da1ee60
[nextest-runner] make leak timeout configurable
sunshowers Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions .config/nextest.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
[profile.default]
final-status-level = "slow"

[profile.ci]
# Don't fail fast in CI to run the full test suite.
fail-fast = false

[[profile.ci.overrides]]
# In CI, and only in CI, some time on 2022-07-10, the integration tests started
# to be flaky on Windows -- the cdylib-link fixture sometimes exits with code
# -1073741515 (0xc0000135; STATUS_DLL_NOT_FOUND). This is flaky, so retry these
# tests a few times.
#
# TODO: restrict these tests to Windows.
filter = '(package(nextest-runner) & binary(integration)) | (package(cargo-nextest) & test(/^tests_integration::/))'
retries = 9

[profile.test-slow]
# This is a test profile with a quick slow timeout.
slow-timeout = "1s"
Expand Down
213 changes: 104 additions & 109 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions cargo-nextest/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ miette = { version = "5.1.1", features = ["fancy"] }
nextest-filtering = { version = "=0.2.0", path = "../nextest-filtering" }
nextest-runner = { version = "=0.17.0", path = "../nextest-runner" }
nextest-metadata = { version = "=0.5.0", path = "../nextest-metadata" }
num_cpus = "1.13.1"
once_cell = "1.13.0"
owo-colors = { version = "3.4.0", features = ["supports-colors"] }
pathdiff = { version = "0.2.1", features = ["camino"] }
Expand Down
Loading