Skip to content

Improve check on redirect URL #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julien-nc merged 1 commit into from
Dec 17, 2025
Merged

Improve check on redirect URL #1273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions lib/Controller/LoginController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,19 @@ private function buildProtocolErrorResponse(?bool $throttle = null): TemplateRes
* @return RedirectResponse
*/
private function getRedirectResponse(?string $redirectUrl = null): RedirectResponse {
return new RedirectResponse(
$redirectUrl === null
? $this->urlGenerator->getBaseUrl()
: preg_replace('/^https?:\/\/[^\/]+/', '', $redirectUrl)
);
if ($redirectUrl === null) {
return new RedirectResponse($this->urlGenerator->getBaseUrl());
}

// Remove protocol and domain name
$filtered = preg_replace('/^https?:\/\/[^\/]+/', '', $redirectUrl);

// Additional check: ensure the result starts with a single /
if (!preg_match('/^\/[^\/]/', $filtered)) {
return new RedirectResponse($this->urlGenerator->getBaseUrl());
}

return new RedirectResponse($filtered);
}

/**
Expand Down
Loading