Prevent multiple simultaneous token refresh #1178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
fix/1175/lock-token-refresh
branch
from
183549e to
61f543e
Compare
julien-nc
force-pushed
the
fix/1175/lock-token-refresh
branch
from
61f543e to
019e2c2
Compare
…, store lock in the php session Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
fix/1175/lock-token-refresh
branch
from
019e2c2 to
17c444d
Compare
pschichtel
reviewed
Nov 23, 2025
Comment on lines
+169
to
+174
| $sessionLocked = $this->session->get(self::REFRESH_LOCK_KEY); | ||
| if ($sessionLocked !== null) { | ||
| throw new TokenRefreshLockedException(); | ||
| } | ||
| // acquire lock | ||
| $this->session->set(self::REFRESH_LOCK_KEY, 1); |
There was a problem hiding this comment.
Isn't this also racy? The set operation would better be some kind of atomic check-and-set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store a lock in the php session.
closes #1175