Skip to content

fix: Exclude Readme.md files from file locking in the text app#8284

Merged
juliusknorr merged 7 commits intonextcloud:mainfrom
rikled:main
Mar 4, 2026
Merged

fix: Exclude Readme.md files from file locking in the text app#8284
juliusknorr merged 7 commits intonextcloud:mainfrom
rikled:main

Conversation

@rikled
Copy link
Contributor

@rikled rikled commented Feb 19, 2026

📝 Summary

This PR excludes Readme files from file locking. Without it is almost impossible to delete these files as they are opened as soon as a user visits the directory of the file. This is meant as an intermediate solution until #5597 is implemented.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@rikled rikled requested a review from juliusknorr February 19, 2026 23:41
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Feb 25, 2026
Copy link
Collaborator

@silverkszlo silverkszlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this by adding temporary debug logging and saw the following output in the nextcloud log, so seems to work :)

{"message":"Attempting to lock file","data":{"fileId":"89","fileName":"regular.md"}}
{"message":"Lock result","data":{"fileId":"89","fileName":"regular.md","isLocked":"true"}}

{"message":"Skipping lock for file","data":{"fileId":"86","fileName":"Readme.md","reason":"Readme.md exception"}}

rikled added 7 commits March 4, 2026 00:03
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
@juliusknorr juliusknorr merged commit 9d30167 into nextcloud:main Mar 4, 2026
63 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README.md is almost always locked

3 participants