fix: Exclude Readme.md files from file locking in the text app#8284
Merged
juliusknorr merged 7 commits intonextcloud:mainfrom Mar 4, 2026
Merged
fix: Exclude Readme.md files from file locking in the text app#8284juliusknorr merged 7 commits intonextcloud:mainfrom
juliusknorr merged 7 commits intonextcloud:mainfrom
Conversation
silverkszlo
approved these changes
Feb 26, 2026
Collaborator
silverkszlo
left a comment
There was a problem hiding this comment.
I've tested this by adding temporary debug logging and saw the following output in the nextcloud log, so seems to work :)
{"message":"Attempting to lock file","data":{"fileId":"89","fileName":"regular.md"}}
{"message":"Lock result","data":{"fileId":"89","fileName":"regular.md","isLocked":"true"}}
{"message":"Skipping lock for file","data":{"fileId":"86","fileName":"Readme.md","reason":"Readme.md exception"}}
juliusknorr
reviewed
Feb 26, 2026
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
juliusknorr
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR excludes Readme files from file locking. Without it is almost impossible to delete these files as they are opened as soon as a user visits the directory of the file. This is meant as an intermediate solution until #5597 is implemented.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)